Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow create client with same source and destination chains #932

Closed
1 of 5 tasks
ancazamfir opened this issue May 12, 2021 · 0 comments · Fixed by #940
Closed
1 of 5 tasks

Disallow create client with same source and destination chains #932

ancazamfir opened this issue May 12, 2021 · 0 comments · Fixed by #940
Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support

Comments

@ancazamfir
Copy link
Collaborator

Crate

relayer-cli

Summary of Bug

This was fixed temporarily in #691 but got lost in same PR cd576de

Version

master

Steps to Reproduce

hermes create client ibc-0 ibc-0

Acceptance Criteria

Return error when same source and dest chains are specified, e.g. hermes create client ibc-0 ibc-0

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support labels May 12, 2021
@romac romac mentioned this issue May 14, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow create client with same source and destination chains informalsystems/hermes
2 participants
@romac @ancazamfir