Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include chain-id in hermes query clients output #992

Closed
5 tasks done
ebuchman opened this issue May 25, 2021 · 0 comments · Fixed by #995
Closed
5 tasks done

Include chain-id in hermes query clients output #992

ebuchman opened this issue May 25, 2021 · 0 comments · Fixed by #995
Assignees
Labels
I: CLI Internal: related to the relayer's CLI
Milestone

Comments

@ebuchman
Copy link
Member

ebuchman commented May 25, 2021

Crate

relayer-cli

Summary

hermes query clients cosmoshub-4 outputs a list of all clients registered on the chain, but it's just the client ids, which isn't that helpful, especially since they're lexicographically ordered:

Success: [
    ClientId(
        "07-tendermint-0",
    ),
    ClientId(
        "07-tendermint-1",
    ),
    ClientId(
        "07-tendermint-10",
    ),
    ClientId(
        "07-tendermint-100",
    ),
    ClientId(
        "07-tendermint-101",
    ),

Of course the ordering is because these are strings, and we don't read the suffix number. It might be good to read the suffix number so we can order properly.

But more important would be to include the ChainID information, otherwise we don't really get anything valuable here since we don't know what each client corresponds to, but if we output the ChainID along with the ClientID it would at least be easier to find clients for particular chains.

Acceptance Criteria

Output of hermes query clients is ordered numerically and includes ChainID along with ClientID


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the 05.2021 milestone May 26, 2021
@adizere adizere self-assigned this May 26, 2021
@adizere adizere added the I: CLI Internal: related to the relayer's CLI label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants