send packet transfer CLI #495

ancazamfir · 2021-01-04T12:00:08Z

Closes: #470

Description

Added the CLI. For example:
tx raw packet-send ibc-0 ibc-1 transfer channel-0 9999 111 -n 3
Initiates three 9999 samoleans ics-20 transfer messages on ibc-0 to be eventually sent to ibc-1, on channel-0 with timeout height offset of 111.
The CLI doesn't use the runtime as we need it to work concurrently with a running relayer (using instead the CosmosSDKChain::bootstrap())
The ics20-fungible-token-transfer is moved under the application module.

For contributor use:

Updated the Unreleased section of CHANGELOG.md with the issue.
If applicable: Unit tests written, added test to CI.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (docs/) and code comments.
Re-reviewed Files changed in the Github PR explorer.

…s into anca/stargate_five

…ms/ibc-rs into anca/stargate_five

…t relaying

codecov-io · 2021-01-04T12:36:56Z

Codecov Report

Merging #495 (68fe607) into master (b1b37f5) will increase coverage by 15.9%.
The diff coverage is 56.4%.

@@            Coverage Diff            @@
##           master    #495      +/-   ##
=========================================
+ Coverage    13.6%   29.6%   +15.9%     
=========================================
  Files          69     160      +91     
  Lines        3752   12814    +9062     
  Branches     1374    5018    +3644     
=========================================
+ Hits          513    3800    +3287     
- Misses       2618    8323    +5705     
- Partials      621     691      +70

Impacted Files	Coverage Δ
...application/ics20_fungible_token_transfer/error.rs	`0.0% <0.0%> (ø)`
...pplication/ics20_fungible_token_transfer/events.rs	`0.0% <ø> (ø)`
...ion/ics20_fungible_token_transfer/msgs/transfer.rs	`0.0% <0.0%> (ø)`
modules/src/events.rs	`0.0% <0.0%> (ø)`
modules/src/ics02_client/events.rs	`0.0% <0.0%> (ø)`
modules/src/ics02_client/msgs.rs	`0.0% <0.0%> (ø)`
modules/src/ics02_client/raw.rs	`0.0% <0.0%> (ø)`
modules/src/ics03_connection/error.rs	`13.6% <0.0%> (-19.7%)`	⬇️
modules/src/ics03_connection/events.rs	`0.0% <0.0%> (ø)`
modules/src/ics04_channel/error.rs	`75.0% <ø> (+50.0%)`	⬆️
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379dd98...68fe607. Read the comment docs.

romac · 2021-01-05T13:01:20Z

modules/src/application/ics20_fungible_token_transfer/msgs/transfer.rs

+    /// the channel by which the packet will be sent
+    pub source_channel: ChannelId,
+    /// the tokens to be transferred
+    pub token: Option<ibc_proto::cosmos::base::v1beta1::Coin>,


At some point (perhaps in a later PR), we should define this Coin type as a domain type (ie. an instance of the Protobuf trait) rather than rely on the protobuf definition directly.

adizere

Done with reading the code. Just had 1 comment.
Still trying out the CLI...

modules/src/application/ics20_fungible_token_transfer/error.rs

adizere

Aside from minor comments (all of which can be fixed later), looks good!

relayer/src/transfer.rs

* Move ics20 in application * Add send packet cli

ancazamfir and others added 30 commits December 12, 2020 21:07

Initial migration changes

69a5ef5

More changes, add some of the ack CLIs

c5946cd

cleanup

05b5cd3

Merge branch 'master' into anca/stargate_five

dfde7d2

fix packet ack

b0c2441

clippy and fmt fixes

070b5f4

Fixed connOpenTry tests; ignored update client tests

f5861d0

Fixed ack msg tests

5dd5665

Added next identifier generation in mock context

dcf108c

Fixed ICS26 tests

a123a2c

Fix for relayer tests

f8136a0

Timeout packet, add Uninit for conn and chan, extract clientId

9a01ed5

Fix option order in packet Tx clis

96a8d98

Tx result parsing (not generalized yet)

9d36ac7

Merge branch 'anca/stargate_five' of github.com:informalsystems/ibc-r…

0c28fc4

…s into anca/stargate_five

add extern paths back

cf1b24c

Merge branch 'anca/stargate_five' of https://github.com/informalsyste…

f5f9064

…ms/ibc-rs into anca/stargate_five

WIP General event parsing out of tx response

7954a87

change packet envelope to packet

339b455

Merge branch 'anca/stargate_five' of https://github.com/informalsyste…

d7d6bad

…ms/ibc-rs into anca/stargate_five

Make the code compile, return clientID in relayer and CLI

1fe58b2

event parsing and matching for conn open init

ce07f63

Change tm dependency, fix update client CLI

a90e0c5

Merge branch 'anca/stargate_five' of https://github.com/informalsyste…

bdd6d87

…ms/ibc-rs into anca/stargate_five

log fix and move to cosmos v0.40.0-rc5 (no changes)

c01ac45

Finished connection CLIs

930c0a0

Event parsing and fixes for channel open CLIs

88bffd5

add more event attributes, some refactor of the packet CLIs and packe…

00ebf1e

…t relaying

cleanup CLI output for channel, add more fields to events

74e5626

Fix relayer connection loop for dynamic IDs

fef4682

ancazamfir added 8 commits December 22, 2020 10:03

Fix relayer channel loop for dynamic IDs, started on config cleanup

e730425

Cleanup relayer config

906ea24

update Changelog

8d6ff87

add send packet cli

26dfd88

reorg

1f8937d

add option to send n messages, default 1

46d55c9

Merge branch 'master' into anca/send_cli

b544516

Merge branch 'master' into anca/send_cli

a418baf

ancazamfir requested a review from romac as a code owner January 4, 2021 12:00

ancazamfir changed the title ~~Anca/send cli~~ send packet CLI Jan 4, 2021

ancazamfir marked this pull request as draft January 4, 2021 12:04

fmt errors

d6a5b78

ancazamfir added 2 commits January 4, 2021 14:33

Merge branch 'master' into anca/send_cli

433db58

Move ics20 in application

aeea390

ancazamfir marked this pull request as ready for review January 5, 2021 12:33

ancazamfir changed the title ~~send packet CLI~~ send packet transfer CLI Jan 5, 2021

ancazamfir changed the base branch from master to adi/326_adr05 January 5, 2021 12:51

ancazamfir changed the base branch from adi/326_adr05 to master January 5, 2021 12:51

romac reviewed Jan 5, 2021

View reviewed changes

adizere reviewed Jan 5, 2021

View reviewed changes

modules/src/application/ics20_fungible_token_transfer/error.rs Outdated Show resolved Hide resolved

adizere approved these changes Jan 5, 2021

View reviewed changes

relayer/src/transfer.rs Outdated Show resolved Hide resolved

relayer/src/transfer.rs Show resolved Hide resolved

review comments

68fe607

ancazamfir merged commit 453c1da into master Jan 5, 2021

ancazamfir deleted the anca/send_cli branch January 5, 2021 17:24

hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022

send packet transfer CLI (informalsystems#495)

3b6bd79

* Move ics20 in application * Add send packet cli

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

send packet transfer CLI #495

send packet transfer CLI #495

ancazamfir commented Jan 4, 2021 •

edited

Loading

codecov-io commented Jan 4, 2021 •

edited

Loading

romac Jan 5, 2021 •

edited

Loading

adizere left a comment

adizere left a comment

send packet transfer CLI #495

send packet transfer CLI #495

Conversation

ancazamfir commented Jan 4, 2021 • edited Loading

Description

codecov-io commented Jan 4, 2021 • edited Loading

Codecov Report

romac Jan 5, 2021 • edited Loading

Choose a reason for hiding this comment

adizere left a comment

Choose a reason for hiding this comment

adizere left a comment

Choose a reason for hiding this comment

ancazamfir commented Jan 4, 2021 •

edited

Loading

codecov-io commented Jan 4, 2021 •

edited

Loading

romac Jan 5, 2021 •

edited

Loading