-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry and Prometheus endpoint #985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
May 26, 2021
adizere
approved these changes
Jun 1, 2021
romac
approved these changes
Jun 1, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Initial telemetry support implementation (informalsystems#868) * Refactored code for state and service. Replaced hyper with rouille (informalsystems#868) * Initial logic to include the telemetry in the Supervisor (informalsystems#868) * Refactored logic into server and service. Server working (informalsystems#868) * Added new methods for state and server (informalsystems#868) * Telemetry service logic working, recording a metric (informalsystems#868) * Added more metrics (informalsystems#868) * Added logic to disable/enable telemetry service and server (informalsystems#868) * Added more metrics to service. Hookup the packet timeout metric (informalsystems#868) * Move telemetry service into `ibc-telemetry` crate * Move `metric!` macro into its own module * Move telemetry config under `[telemetry]` section * Disable telemetry by default, fix port to 3001 * Try to fix libm.so error * Wrap telemetry state in Arc and simplify server a little * Simplify server a bit more * Fix glibc version mismatch between CI and Docker image * Push telemetry handle down into workers * Implement `workers`, `ibc_client_misbehaviours` and `receive_packets` metrics * Add `ibc_client_update` metric * Remove need for telemetry service by passing around the telemetry state * Add ack and timeout metrics * Fix compilation when telemetry feature is not included * FMT * Rename metric! macro to telemetry! * Add `clippy --no-default-features` to CI Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #868
Description
Adds telemetry to Hermes and exposes an Prometheus endpoint.
Testing
[telemetry]
section:In a separate terminal, watch the telemetry (please ensure the port matches the one specified in the
telemetry.port
config parameterExpect the output to look like
Run the e2e test trigger other metrics....
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.