Hermes channel create creates un-opened channel

[adizere]

Crate

ibc-relayer

Summary of Bug

The command hermes create channel create a new channel, but only one end of the channel is Open, while the other end is TryOpen. In other words, Hermes omits sending the final OpenConfirm step to side 'b' of the channel.

Using a default config.toml from current master:

> hermes create channel ibc-0 ibc-1 --port-a transfer --port-b transfer
# ...
# the last step, before returning success is as OpenAck (instead of OpenConfirm):
# 
Jun 08 13:42:33.953  INFO ibc_relayer::channel: done ibc-0 => OpenAckChannel(
    OpenAck(
        Attributes {
            height: Height {
                revision: 0,
                height: 244,
            },
            port_id: PortId(
                "transfer",
            ),
            channel_id: Some(
                ChannelId(
                    "channel-0",
                ),
            ),
            connection_id: ConnectionId(
                "connection-0",
            ),
            counterparty_port_id: PortId(
                "transfer",
            ),
            counterparty_channel_id: Some(
                ChannelId(
                    "channel-0",
                ),
            ),
        },
    ),
)

Querying the channel ends shows that the channel is open only on one side..

> hermes query channel end ibc-0 transfer channel-0
Success: ChannelEnd {
    state: Open,                <<<<<<-------- This is Open
    ordering: Unordered,
    remote: Counterparty {
        port_id: PortId(
            "transfer",
        ),
        channel_id: Some(
            ChannelId(
                "channel-0",
            ),
        ),
    },
    connection_hops: [
        ConnectionId(
            "connection-0",
        ),
    ],
    version: "ics20-1",
}

> hermes query channel end ibc-1 transfer channel-0
Success: ChannelEnd {
    state: TryOpen,                <<<<<<-------- Should be Open
    ordering: Unordered,
    remote: Counterparty {
        port_id: PortId(
            "transfer",
        ),
        channel_id: Some(
            ChannelId(
                "channel-0",
            ),
        ),
    },
    connection_hops: [
        ConnectionId(
            "connection-0",
        ),
    ],
    version: "ics20-1",
}

Version

2b84667

The bug is recent, since we didn't observe it in v0.4.0. I did a quick check of this bug against commit dc6e840, and the bug does not manifest there. So the bug probably originates from recent changes around the channel, e.g., c375c71.

Steps to Reproduce

> hermes create channel ibc-0 ibc-1 --port-a transfer --port-b transfer
> hermes query channel end ibc-0 transfer channel-0
> hermes query channel end ibc-1 transfer channel-0

Acceptance Criteria

• the channel ends on both sides should be in state Open if command hermes create channel ends with a Success status

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned