-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding key generation algorithm for "eth_secp256k1" #1071
Comments
This seems related to #1155. @leejw51crypto we plan to get to this by end of October. Please let us know if that timeline is OK, or if you have more specific time constraints in mind. |
We at InjectiveLabs also run Ethermint-compatible chain, implemented full support for the |
@devashishdxt I just got up to the 2nd point. Debugging to see what's wrong there on the ibc-rs side. |
) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey")
) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey")
) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey")
* added Ethermint support (fixes #1267 #1071) - collected changes from #1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey") * added a comment for eth address and change query_account return type back to BaseAccount * check the public key type in ethermint address generation * added a check on `sign_msg` * added comments + reordered example config * added links with information for testing Ethermint * adjusted a comment for `EthAccount` Co-authored-by: Romain Ruetschi <romain@informal.systems>
* added Ethermint support (fixes informalsystems#1267 informalsystems#1071) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey") * added a comment for eth address and change query_account return type back to BaseAccount * check the public key type in ethermint address generation * added a check on `sign_msg` * added comments + reordered example config * added links with information for testing Ethermint * adjusted a comment for `EthAccount` Co-authored-by: Romain Ruetschi <romain@informal.systems>
currently, we can generate keys like this, default algo is secp256k1
that's different from ethermint's one.
so we can add like this
so user can freely designate 20 payload address representaion algorithm.
for example
also we can support other cosmos network which uses different address logic.
The text was updated successfully, but these errors were encountered: