Misbehavior check triggered by UpdateClient event may run for a long time

[ancazamfir]

Crate

relayer

Summary of Bug

Function detect_misbehaviour() calls:
https://github.com/informalsystems/ibc-rs/blob/5d53e5279d765024913494a129c55e9bf780c409/relayer/src/foreign_client.rs#L958

in all invocations. This may result in long processing times for misbehaviour detection for a specific UpdateClient. It should only be needed when hermes does a first crawl/ verification of all consensus states on start. I think it should not be required after that.

Version

master

Steps to Reproduce

The delay should be noticeable in the client worker processing of UpdateClient events for clients created on cosmoshub and that are heavily used (e.g. the client used by the osmosis - hub channel). Logs should show a big misbehaviour check time.

Acceptance Criteria

Reduce misbehaviour check duration.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned