Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect acknowledgement verification #46

Closed
5 tasks
hu55a1n1 opened this issue Apr 22, 2022 · 0 comments · Fixed by informalsystems/hermes#2105
Closed
5 tasks

Incorrect acknowledgement verification #46

hu55a1n1 opened this issue Apr 22, 2022 · 0 comments · Fixed by informalsystems/hermes#2105
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Apr 22, 2022 •
edited
Loading

Summary of Bug

The verify_packet_acknowledgement() function is incorrectly verifying the packet ack bytes instead of the ack commitment.
https://github.com/informalsystems/ibc-rs/blob/5e886ca6f1f0b131cba9c6ed9c90501dd5cfcdd0/modules/src/core/ics04_channel/handler/verify.rs#L99-L132

Version

v0.13.0

Acceptance Criteria

Correct verification of acks.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 mentioned this issue Apr 22, 2022
Merged
6 tasks
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Apr 25, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix packet commitment computation and incorrect ack verification yito88/ibc-rs
1 participant
@hu55a1n1