Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment and fix client query commands #231

Closed
1 of 4 tasks
ancazamfir opened this issue Sep 15, 2020 · 3 comments · Fixed by #235
Closed
1 of 4 tasks

Uncomment and fix client query commands #231

ancazamfir opened this issue Sep 15, 2020 · 3 comments · Fixed by #235
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Summary of Bug

The client query commands for state and consensus are currently commented out as the initial query infrastructure was changed.
The code should be uncommented and fixed so it works at least up to the deserialization.


  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ebuchman
Copy link
Member

Maybe let's not bother with things that "work up to deserialization" and just fix it once we can go all the way through, including deserialization? Should be soon given progress on tendermint-rs

@ancazamfir
Copy link
Collaborator Author

We will need this for the relayer MVP where we short-circuit the serialization/ deserialization. It's also a good validation that the way we model the multiple client types and their states, consensus, etc. is good.

@adizere
Copy link
Member

adizere commented Sep 16, 2020

This is a sub-issue of #128.

The query logic used to be there, unsatisfactory, so it was mostly cut out in #174 where the infrastructure around queries changes. What's left can be seen in relayer/src/query/client.rs.

@adizere adizere added this to the v0.0.4 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants