Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for gas multiplier may cause Tx failures due to gas estimation #2435

Closed
5 tasks
ancazamfir opened this issue Jul 19, 2022 · 0 comments · Fixed by #2443
Closed
5 tasks

Default value for gas multiplier may cause Tx failures due to gas estimation #2435

ancazamfir opened this issue Jul 19, 2022 · 0 comments · Fixed by #2443
Assignees
@romac
Labels
A: bug Admin: something isn't working
Milestone
v1.0.0

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Jul 19, 2022 •
edited
Loading

Summary of Bug

The DEFAULT_GAS_MULTIPLIER of 1.0 is not enough in most cases to successfully submit a transaction. It should be increased to at least 1.1 which is the equivalent of the old DEFAULT_GAS_ADJUSTMENT.

Version

v1.0.0-rc0, master

Steps to Reproduce

Acceptance Criteria

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere modified the milestones: v1.1, v1.0.0 Jul 20, 2022
@romac romac self-assigned this Jul 20, 2022
@romac romac mentioned this issue Jul 20, 2022
Merged
6 tasks
@adizere adizere added the A: bug Admin: something isn't working label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Increase default gas multiplier to 1.1 informalsystems/hermes
3 participants
@romac @adizere @ancazamfir