You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some IBC proto files (e.g. ibc.tendermint.rs::Header) need to reference some other proto files and structures (e.g. tendermint.types.rs::SignedHeader or tendermint.types.rs::ValidatorSet) that belong to tendermint-rs where we expect the conversions between raw and domain types are implemented.
Presently the ibc-proto files point to duplicate tendermint files in ibc-proto, in particular tendermint.types.rs for the examples above. But I believe all tendermint files in IBC proto are dups of the ones in tendermint-rs
Version
master
Steps to Reproduce
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
This is blocking progress for #277 where I get errors like:
^^^^ the trait std::convert::From<ibc_proto::tendermint::types::SignedHeader> is not implemented for tendermint::block::signed_header::SignedHeader
I would expect at most something like:
^^^^ the trait std::convert::From<tendermint_proto::types::SignedHeader> is not implemented for tendermint::block::signed_header::SignedHeader
if the conversion is not implemented yet in tendermint-rs.
Because we compile the messages separately in Prost, the IBC Prost compiler doesn't know about a separate set of messages in the Tendermint repository and compiles them as it sees them.
We have to figure out if we can merge the two protobuf message folders together either at the source or during compilation into Rust structs. Or as a third option, somehow separate the Tendermint-related messages in the Cosmos SDK.
I'm not sure, but the copy of Tendermint messages is definitely problematic.
Summary of Bug
Some IBC proto files (e.g.
ibc.tendermint.rs::Header
) need to reference some other proto files and structures (e.g.tendermint.types.rs::SignedHeader
ortendermint.types.rs::ValidatorSet
) that belong to tendermint-rs where we expect the conversions between raw and domain types are implemented.Presently the ibc-proto files point to duplicate tendermint files in ibc-proto, in particular
tendermint.types.rs
for the examples above. But I believe alltendermint
files in IBC proto are dups of the ones intendermint-rs
Version
master
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: