Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a specific commit of the SDK to check out when compiling protos #17

Closed
5 tasks done
romac opened this issue Nov 5, 2020 · 0 comments
Closed
5 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Nov 5, 2020

Crate

proto-compiler and ibc-proto

Summary

Allow specifying a specific commit of the SDK to check out when compiling protos.

Problem Definition

We currently have no idea which version of the SDK the protos we compile to Rust code are from, because the proto-compiler crate checks the latest master of the SDK when cloning it.

Proposal

a) Specify which commit to checkout when we clone the SDK with proto-compiler
b) Expose the commit at which we fetched the .proto definitions in the ibc-proto library


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the enhancement New feature or request label Nov 5, 2020
@romac romac self-assigned this Nov 5, 2020
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant