Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel open handshake message relaying/CLIs #403

Merged
merged 8 commits into from
Nov 19, 2020
Merged

Conversation

ancazamfir
Copy link
Collaborator

Closes: #371 #372 #373 #374

Description

  • CLIs for channel open handshake messages
  • building and relaying of channel open handshake messages

[will revert the Cargo.toml changes for tendermint dependencies after more testing]


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@ancazamfir ancazamfir requested a review from romac as a code owner November 17, 2020 09:28
@ancazamfir ancazamfir self-assigned this Nov 17, 2020
@ancazamfir ancazamfir requested a review from adizere November 17, 2020 09:29
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #403 (6ed24df) into master (b1b37f5) will increase coverage by 19.7%.
The diff coverage is 66.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #403      +/-   ##
=========================================
+ Coverage    13.6%   33.4%   +19.7%     
=========================================
  Files          69     154      +85     
  Lines        3752   10296    +6544     
  Branches     1374    3780    +2406     
=========================================
+ Hits          513    3442    +2929     
- Misses       2618    6245    +3627     
+ Partials      621     609      -12     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 13.6% <0.0%> (-19.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/msgs/acknowledgement.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/msgs/chan_open_try.rs 66.8% <ø> (ø)
modules/src/ics04_channel/msgs/recv_packet.rs 0.0% <ø> (ø)
modules/src/ics04_channel/msgs/timeout.rs 0.0% <ø> (ø)
... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b641f79...6ed24df. Read the comment docs.

@ancazamfir ancazamfir changed the title Anca/chain init tx channel open handshake message relaying/CLIs Nov 17, 2020
@ancazamfir ancazamfir changed the title channel open handshake message relaying/CLIs Channel open handshake message relaying/CLIs Nov 17, 2020
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The present version seems to have compilation issues, following recent changes in tendermint-rs master (domaintype redefined to protobuf). So we should remember to revert cargo modifications, or adapt to these changes.

Otherwise looks good IMO!

modules/src/ics04_channel/channel.rs Outdated Show resolved Hide resolved
relayer-cli/src/commands/tx/channel.rs Show resolved Hide resolved
@ancazamfir ancazamfir requested a review from adizere November 19, 2020 12:19
@ancazamfir ancazamfir merged commit 0409703 into master Nov 19, 2020
@ancazamfir ancazamfir deleted the anca/chain_init_tx branch November 19, 2020 14:07
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Add chan init and try CLIs

* Add ack and confirm CLIs

* Move to tendermint rc3

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relayer CLI for MsgChannelOpenInit
3 participants