Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ics23 to v0.10 to get prehash_key_before_comparison #640

Closed
Tracked by #608
kevinji opened this issue Apr 19, 2023 · 4 comments · Fixed by #700
Closed
Tracked by #608

Bump ics23 to v0.10 to get prehash_key_before_comparison #640

kevinji opened this issue Apr 19, 2023 · 4 comments · Fixed by #700
Milestone

Comments

@kevinji
Copy link
Contributor

kevinji commented Apr 19, 2023

Feature Summary

ics23 v0.10 includes cosmos/ics23#136 which is needed for certain Merkle tree implementations. We would like to pick this up, but I think this is blocked on ibc-proto-rs getting the prehash_key_before_comparison field in ibc_proto::ics23::ProofSpec.

Fixing cosmos/ibc-proto-rs#10 would make it easier to pick up upstream ics23 changes.

Proposal

Bump ics23 to v0.10 after making the needed changes in ibc-proto-rs.

@kevinji kevinji changed the title Bump ics23 to v0.10 to get prehash_compare_key Bump ics23 to v0.10 to get prehash_key_before_comparison Apr 19, 2023
@romac
Copy link
Member

romac commented Apr 19, 2023

I am working on cosmos/ibc-proto-rs#10, will keep you posted.

@romac
Copy link
Member

romac commented Apr 19, 2023

I opened a draft PR in ibc-proto-rs: cosmos/ibc-proto-rs#92

Currently blocked on getting this in ics23: cosmos/ics23#145

@Farhad-Shabani Farhad-Shabani moved this to ✅ Done in ibc-rs Apr 25, 2023
@romac
Copy link
Member

romac commented May 2, 2023

It's out: https://github.com/cosmos/ibc-proto-rs/releases/tag/v0.31.0-alpha.1

@plafer
Copy link
Contributor

plafer commented May 2, 2023

We can't quite upgrade yet because it depends on tendermint-proto v0.31.0, but tower-abci only supports v0.30.0 at the moment (which most of our users use)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants