Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete implementation of ICS-02 verification functions #28

Closed
5 tasks
devashishdxt opened this issue Mar 5, 2021 · 1 comment
Closed
5 tasks

Incomplete implementation of ICS-02 verification functions #28

devashishdxt opened this issue Mar 5, 2021 · 1 comment

Comments

@devashishdxt
Copy link

devashishdxt commented Mar 5, 2021 •
edited by adizere
Loading

Crate

modules/src/ics02_client

Summary

Not all the functions in ICS-02 are included in ClientDef trait.

Problem Definition

I'm working on ICS-06 solo machine client implementation and found that a few functions mentioned in ICS-02 client specifications are missing from ClientDef trait in modules/src/ics02_client. To fully implement any client for IBC, we'll need these functions in base traits.

Proposal

Add missing functions ClientDef trait. Currently, the ClientDef trait contains following functions:

  • check_header_and_update_state
  • verify_client_consensus_state
  • verify_connection_state
  • verify_channel_state
  • verify_client_full_state

Following functions are missing:

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere changed the title Incomplete implementation of ICS-02 Incomplete implementation of ICS-02 verification functions Mar 18, 2021
@adizere adizere mentioned this issue Mar 18, 2021
Closed
@adizere adizere mentioned this issue Mar 26, 2021
Closed
@hu55a1n1 hu55a1n1 mentioned this issue Nov 12, 2021
Open
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 28, 2022
livelybug referenced this issue in octopus-network/ibc-rs Oct 14, 2022
@ancazamfir
[WIP] Relayer ADR and diagrams (#28)
8e73a85 
* relayer ADR and diagrams

* some review comments

* Relayer ADR updates, move to Rust structs, small config changes

* cargo fmt

* clean figure

* add client heights diagram and explanation, some doc corrections

* corrections on event handling diagram, added also consensus state events

* small fixes before merge
@plafer
Copy link
Contributor

plafer commented Dec 13, 2022

Closing this as stale and mostly a duplicate of the most recent #173.

@plafer plafer closed this as completed Dec 13, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@ethanfrey
Merge pull request cosmos#28 from confio/update-proto-spec
1a0acff 
Update proto spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plafer @devashishdxt