Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawn a single Tokio runtime for the whole supervisor instead of one per chain #909

Closed
5 tasks done
romac opened this issue May 6, 2021 · 0 comments · Fixed by #910
Closed
5 tasks done

Spawn a single Tokio runtime for the whole supervisor instead of one per chain #909

romac opened this issue May 6, 2021 · 0 comments · Fixed by #910
Assignees
@romac
Labels
A: bug Admin: something isn't working I: logic Internal: related to the relaying logic
Milestone
04.2021

Comments

@romac
Copy link
Member

romac commented May 6, 2021 •
edited
Loading

Crate

relayer

Summary of Bug

The Supervisor, via the Registry, spawns a whole new Tokio runtime per chain runtime.
We should instead instantiate a single Tokio runtime in the Registry and re-use it.

Version

22a0a3f

Steps to Reproduce

n/a

Acceptance Criteria

The supervisor only spawns a single Tokio runtime via the Registry.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac self-assigned this May 6, 2021
@romac romac added this to the 04.2021 milestone May 6, 2021
@romac romac mentioned this issue May 6, 2021
Merged
5 tasks
@adizere adizere added A: bug Admin: something isn't working I: logic Internal: related to the relaying logic labels May 6, 2021
@ancazamfir ancazamfir mentioned this issue May 6, 2021
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
A: bug Admin: something isn't working I: logic Internal: related to the relaying logic
Projects
None yet
Milestone
04.2021
Development

Successfully merging a pull request may close this issue.

Spawn a single Tokio runtime + new clippy lints informalsystems/hermes
2 participants
@romac @adizere