Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message shown when connection name is wrong could be improved #920

Closed
2 of 5 tasks
andynog opened this issue May 10, 2021 · 0 comments · Fixed by #923
Closed
2 of 5 tasks

Error message shown when connection name is wrong could be improved #920

andynog opened this issue May 10, 2021 · 0 comments · Fixed by #923
Assignees
Labels
O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@andynog
Copy link
Contributor

andynog commented May 10, 2021

Crate

ibc-relayer-cli

Summary of Bug

I was trying to execute a tx raw chan-open-init transaction and I typed the wrong connection name, and the error message returned is not very helpful to the end user.

Version

Branch: master
Commit: 1adb18d3d4c70239115bc5d98abeb8d114cf9c15

Steps to Reproduce

Type the wrong connection name (should be connection-201 not connections-201)

hermes tx raw chan-open-init cosmoshub-4 irishub-1 connections-201 transfer tranfer -o UNORDERED
May 10 17:26:27.544  INFO ibc_relayer_cli::commands: Using default configuration from: '.hermes/config.toml'
May 10 17:26:27.606  INFO ibc_relayer::event::monitor: starting event monitor chain.id=irishub-1
May 10 17:26:27.662  INFO ibc_relayer::event::monitor: starting event monitor chain.id=cosmoshub-4
Error: Query error occurred (failed to finish query for connection connections-201): error converting message type into domain type: ConnectionEnd domain object could not be constructed out of empty proto object

The error message returned shows a message about converting into domain type which from a UX perspective is not helpful to the end user. A simpler message saying that the connection cannot be found would be more appropriate.

I have tested with another tx raw (chain-open-try) command and the same error happens.

Acceptance Criteria

Shows a better error message for this use case.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@andynog andynog added O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product labels May 10, 2021
@ancazamfir ancazamfir self-assigned this May 11, 2021
@ancazamfir ancazamfir added this to the 05.2021 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants