Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet Domain Types #134

Closed
Shivani912 opened this issue Jun 10, 2020 · 0 comments
Closed

Packet Domain Types #134

Shivani912 opened this issue Jun 10, 2020 · 0 comments
Assignees

Comments

@Shivani912
Copy link

Shivani912 commented Jun 10, 2020

Problem

The packet, acknowledgement, and timeout messages are missing domain type implementations.

Proposal

Similarly with #105 (channel messages), we need to:

[] Add the From/TryFrom impls for all messages pertaining to packets and supporting structures where missing
[] Make sure tests are aligned wrt raw messages and test (de)serialization
[x] Split the msgs.rs file in per message modules -- this will be handled in #105 alongside all other ICS4 messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants