Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default for max_gas pre defined #1636

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Increase default for max_gas pre defined #1636

merged 3 commits into from
Dec 7, 2021

Conversation

dualsystems
Copy link
Contributor

@dualsystems dualsystems commented Dec 2, 2021 •
edited by adizere
Loading

Description

Increase default for max_gas constant

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Manually tested (in case integration/unit/mock tests are absent).
  • Reviewed Files changed in the GitHub PR explorer.

@dualsystems dualsystems changed the title Increase default for max_gas contains Increase default for max_gas pre defined Dec 3, 2021
adizere
adizere requested changes Dec 3, 2021
View reviewed changes
relayer/src/chain/cosmos.rs Show resolved Hide resolved
adizere
adizere approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dualsystems, LGTM!

@adizere adizere merged commit 86ce870 into informalsystems:master Dec 7, 2021
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@adizere
Increase default for max_gas pre defined (informalsystems#1636)
318c9ef 
* Increase default for max_gas contains

* changelog, consistent defaults for max_gas

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dualsystems @adizere