Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTP Basic authentication in HTTP and WebSocket RPC clients #1169

Closed
romac opened this issue Jul 28, 2022 · 1 comment · Fixed by #1170
Closed

Support for HTTP Basic authentication in HTTP and WebSocket RPC clients #1169

romac opened this issue Jul 28, 2022 · 1 comment · Fixed by #1170
Assignees
Labels
enhancement New feature or request feature rpc

Comments

@romac
Copy link
Member

romac commented Jul 28, 2022

Version(s) of tendermint-rs:

Summary

Add support for HTTP Basic authentication in HTTP and WebSocket RPC clients.

Problem definition

On the Hermes, we have heard a request from some operators to allow them to connect to a full node protected by HTTP Basic authentication.

We initially thought that simply embedding the username and password in the RPC/WebSocket URL (eg. http://username:password@example.com:1234) would work but it does not.

It seems like hyper does not automatically parse and use the username/password embedded in the URL. Instead, we have to manually add an Authorization header to the request.

Same thing with (async-)tungstenite, we have to manually set the Authorization header when building the initial HTTP request that upgrades the connection to WebSocket.

Proposal

Implement support for HTTP Basic authentication for the HTTP and WebSocket clients in tendermint-rpc.

Acceptance criteria

  1. Both the HTTP and WebSocket clients can connect to a node protected by HTTP Basic authentication.
  2. Hermes can connect to a node protected by HTTP Basic authentication. See how to reproduce this on the linked issue.
@thanethomson
Copy link
Contributor

Closed by #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature rpc
Projects
None yet
2 participants