Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common Hash type #1221

Closed
tony-iqlusion opened this issue Nov 1, 2022 · 2 comments
Closed

Common Hash type #1221

tony-iqlusion opened this issue Nov 1, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tony-iqlusion
Copy link
Collaborator

It seems the original tendermint::abci::Hash has moved to tendermint_rpc::abci::transaction::Hash.

There's also tendermint::hash::Hash.

Perhaps tendermint_rpc should use tendermint::hash::Hash for that? If not, it'd be nice to have a From conversion available.
@tony-iqlusion tony-iqlusion added the enhancement New feature or request label Nov 1, 2022
@tony-iqlusion tony-iqlusion mentioned this issue Nov 1, 2022
Merged
@thanethomson
Copy link
Contributor

@tony-iqlusion have you seen #1204?

@tony-iqlusion
Copy link
Collaborator Author

tony-iqlusion commented Nov 2, 2022 •
edited
Loading

I had not. That looks perfect, thanks!

Guess this issue is a dup of #1090.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thanethomson @tony-iqlusion