Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tendermint::Hash's FromStr should be case-insensitive #1279

Open
hdevalence opened this issue Mar 5, 2023 · 2 comments
Open

tendermint::Hash's FromStr should be case-insensitive #1279

hdevalence opened this issue Mar 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@hdevalence
Copy link
Collaborator

Description

Recently I encountered an unintuitive error in pcli: penumbra-zone/penumbra#2092

The cause was that tendermint::Hash's FromStr implementation is case-sensitive, so decoding a lower-case hash failed. We worked around this by uppercasing the string, but it feels like hash parsing should be case-insensitive.

Definition of "done"

Hash parsing should be case-insensitive.

@hdevalence hdevalence added the enhancement New feature or request label Mar 5, 2023
@mzabaluev
Copy link
Contributor

mzabaluev commented Mar 6, 2023

It seems that upper-case has been working for our users since 91c3915. @tony-iqlusion were there any reasons to restrict the hash parsing to uppercase hexadecimals?

@tony-iqlusion
Copy link
Collaborator

I'm confused how 91c3915 could've broken anything. It's purely additive?

There was no intent to restrict mixed case or prefer one case over another, it's just unsupported in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants