Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light-client: feature guard tokio dependency #425

Closed
romac opened this issue Jul 9, 2020 · 1 comment · Fixed by #689
Closed

light-client: feature guard tokio dependency #425

romac opened this issue Jul 9, 2020 · 1 comment · Fixed by #689
Labels
enhancement New feature or request light-client Issues/features which involve the light client

Comments

@romac
Copy link
Member

romac commented Jul 9, 2020

The light-client crate currently depends on tokio unconditionally, but this dependency is only used in concrete, tendermint specific instances of the Io and EvidenceReporter traits.

I suggest feature-guarding these implementations, and thus the tokio dependency to not needlessly burden downstream users of the crate.
@romac romac added enhancement New feature or request light-client Issues/features which involve the light client labels Jul 9, 2020
@xla xla changed the title Feature guard tokio dependency light-client: feature guard tokio dependency Jul 18, 2020
@romac romac mentioned this issue Nov 19, 2020
Merged
5 tasks
@romac
Copy link
Member Author

romac commented Nov 19, 2020 •
edited
Loading

We may even be able to remove the dependency on tendermint-rpc altoghether when the roc-client feature is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request light-client Issues/features which involve the light client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

light-client: Only require Tokio when rpc-client feature is enabled informalsystems/tendermint-rs
1 participant
@romac