Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade sled to 0.34.1 #490

Closed
tomtau opened this issue Jul 29, 2020 · 2 comments · Fixed by #539
Closed

upgrade sled to 0.34.1 #490

tomtau opened this issue Jul 29, 2020 · 2 comments · Fixed by #539
Assignees
Labels
dependencies Pull requests that update a dependency file light-client Issues/features which involve the light client
Milestone

Comments

@tomtau
Copy link
Contributor

tomtau commented Jul 29, 2020

https://github.com/spacejam/sled/blob/master/CHANGELOG.md#0341

@xla xla added dependencies Pull requests that update a dependency file light-client Issues/features which involve the light client labels Aug 4, 2020
@xla xla added this to the v0.16.0 milestone Aug 4, 2020
@greg-szabo greg-szabo self-assigned this Aug 26, 2020
@greg-szabo greg-szabo mentioned this issue Aug 26, 2020
5 tasks
@thanethomson
Copy link
Contributor

How does this affect the Light Client's operations?

Also, how do we manually test whether upgrading breaks the store? (Since we don't have capacity to write automated tests for this upgrade just yet).

@thanethomson thanethomson modified the milestones: v0.16.0, v0.17.0 Aug 28, 2020
@tomtau
Copy link
Contributor Author

tomtau commented Aug 31, 2020

How does this affect the Light Client's operations?

In 0.34.2: "transactions and writebatch performance has been significantly improved by removing a bottleneck in the atomic batch stability tracking code."

Also, how do we manually test whether upgrading breaks the store? (Since we don't have capacity to write automated tests for this upgrade just yet).

maybe having a test script that will produce a binary blob with 0.33 / old binary release and try to read it with the upgraded version, asserting it contains all expected values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file light-client Issues/features which involve the light client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants