Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate, deduplicate, reorganize remaining amino_types #536

Closed
greg-szabo opened this issue Aug 26, 2020 · 2 comments · Fixed by #592
Closed

Consolidate, deduplicate, reorganize remaining amino_types #536

greg-szabo opened this issue Aug 26, 2020 · 2 comments · Fixed by #592
Assignees
Milestone

Comments

@greg-szabo
Copy link
Member

After all amino encoding was changed to protobuf, rename the folder name (and all outstanding comments).

This is considered the last step because reviewing folder renames is cumbersome.

@ebuchman
Copy link
Member

As discussed, we might be able to do away with this folder completely. Previous it held amino types which are now effectively our raw types in the proto crate. I think all that's left are Canonical types for signing and request/response types for the KMS, which should be moved into their own modules. The rest of the types should be redundant with our domain types and should be consolidated with them.

@ebuchman ebuchman changed the title Rename folder amino_types to types Consolidate, deduplicate, reorganize remaining amino_types Sep 16, 2020
@greg-szabo
Copy link
Member Author

Additional note: with #571 we have the ability to get rid of the AminoMessage trait. Let's do that too in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants