Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support consensus state in tendermint rpc #674

Closed
zmanian opened this issue Nov 13, 2020 · 4 comments · Fixed by #719
Closed

Support consensus state in tendermint rpc #674

zmanian opened this issue Nov 13, 2020 · 4 comments · Fixed by #719
Assignees
Labels
Milestone

Comments

@zmanian
Copy link
Contributor

zmanian commented Nov 13, 2020

I would like to be able to write consensus monitoring systems in rust.

The consensus_state endpoint can be very helpful for doing that.

This can be used to badger validators who aren't live yet.

@ebuchman ebuchman added the rpc label Nov 13, 2020
@thanethomson thanethomson self-assigned this Nov 13, 2020
@thanethomson thanethomson added this to the v0.17.0 milestone Nov 19, 2020
@thanethomson
Copy link
Contributor

@zmanian, do you want the RPC to automatically parse the vote strings and vote bit arrays returned by this endpoint?

@zmanian
Copy link
Contributor Author

zmanian commented Dec 2, 2020

So I started to make something like this.

https://github.com/iqlusioninc/tm-launch-monitor/blob/main/main.go#L94-L122

This kind of tooling is sorely needed in the tendermint ecosystem.

Pulling apart the vote strings is a bit messy and I think it's why no standard blame tool has emerged.

I can see more usage for parsed vote strings than I can for the vote bit array.

@thanethomson
Copy link
Contributor

Awesome, I've just added rudimentary support for the consensus_state endpoint in #719, but it just returns the vote strings and vote bit arrays in their string form. I'll work on parsing them tomorrow.

@thanethomson
Copy link
Contributor

@zmanian, do you think the abstractions here would work for you for the vote strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants