You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
unimplemented!()// Prost adds extra annotations on top of Sum that are not used.
}
}
implFrom<EvidenceVariant>forSum{
fnfrom(_:EvidenceVariant) -> Self{
unimplemented!()// Prost adds extra annotations on top of Sum that are not used.
}
}
The comment seems to imply they won't ever be called, so it shouldn't be a problem, but perhaps it would worth looking into removing them altogether while we're at it.
The text was updated successfully, but these errors were encountered:
The serializers for
tendermint::types::{Evidence, evidence::Sum}
are incomplete and may cause a panic in the relayer.The panic happens in this
From
instance, which should likely be converted to aTryFrom
instance:tendermint-rs/proto/src/serializers/evidence.rs
Lines 30 to 38 in 4cbf727
Additionally, these
From
instances are currentlyunimplemented!
:tendermint-rs/proto/src/serializers/evidence.rs
Lines 40 to 50 in 4cbf727
The comment seems to imply they won't ever be called, so it shouldn't be a problem, but perhaps it would worth looking into removing them altogether while we're at it.
The text was updated successfully, but these errors were encountered: