Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: Propagate JSON-RPC errors through the Rust subscription #932

Closed
romac opened this issue Jul 16, 2021 · 0 comments · Fixed by #929
Closed

rpc: Propagate JSON-RPC errors through the Rust subscription #932

romac opened this issue Jul 16, 2021 · 0 comments · Fixed by #929
Assignees
@romac
Labels
enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Jul 16, 2021

Emit JSON-RPC errors sent through the WS subscription through the Subscription channel, so that the Hermes event monitor can detect those (eg. when the WS subscription is closed by the Tendermint node) and attempt to resubscribe.
@romac romac added the enhancement New feature or request label Jul 16, 2021
@romac romac self-assigned this Jul 16, 2021
@romac romac mentioned this issue Jul 16, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate JSON-RPC errors through the Rust subscription informalsystems/tendermint-rs
1 participant
@romac