Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Commands shouldn't need @BotKube prefix if posted as DM to BotKube user #115

Closed
PrasadG193 opened this issue Jul 3, 2019 · 2 comments · Fixed by #116
Closed

[BUG] Commands shouldn't need @BotKube prefix if posted as DM to BotKube user #115

PrasadG193 opened this issue Jul 3, 2019 · 2 comments · Fixed by #116
Assignees
@PrasadG193
Labels
bug Something isn't working mattermost slack

Comments

@PrasadG193
Copy link
Collaborator

Describe the bug
It feels kind of weird to add @botkube prefix in the commands when posting as direct message to BotKube

Expected behavior
BotKube should serve commands with or without @botkube prefix if posted as DM
@PrasadG193 PrasadG193 added the bug Something isn't working label Jul 3, 2019
@PrasadG193 PrasadG193 self-assigned this Jul 3, 2019
@PrasadG193 PrasadG193 mentioned this issue Jul 4, 2019
Merged
@PrasadG193
Copy link
Collaborator Author

Same behaviour observed on Mattermost integration. Reopening the issue

@PrasadG193 PrasadG193 reopened this Jul 5, 2019
@rkennedy-tpl
Copy link

has this actually be solved or do I need to perform additional Slack configuration? it responds to at least ping but most other commands appear ignored.

image

INFO[2021-04-12T23:25:53Z] Invalid request. Dumping the response. Request: help 
INFO[2021-04-12T23:26:42Z] Invalid request. Dumping the response. Request: notifier status 
INFO[2021-04-12T23:27:40Z] Invalid request. Dumping the response. Request:  notifier status

I tried with tag: v0.12.0 and also tried on -latest. (I got a friendly warning for doing that too!)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrasadG193 PrasadG193

Labels
bug Something isn't working mattermost slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat DM as a valid incoming message PrasadG193/botkube
2 participants
@PrasadG193 @rkennedy-tpl