Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kubernetes/Helm] Make cert usage generic #160

Closed
rajinator opened this issue Aug 18, 2019 · 1 comment
Closed

[Kubernetes/Helm] Make cert usage generic #160

rajinator opened this issue Aug 18, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone
v0.9.0

Comments

@rajinator
Copy link
Contributor

rajinator commented Aug 18, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently custom cert is only supported if the mattermost section is enabled, and a cert is specified for it. If behind a network that uses custom SSL, communications to slack or ELK won't work.

Describe the solution you'd like
Make cert support generic, move cert value, and logic out of the mattermost: block.

Additional context
I'll be adding an example PR soon
@rajinator rajinator added the enhancement New feature or request label Aug 18, 2019
@rajinator rajinator mentioned this issue Aug 18, 2019
Merged
@rajinator rajinator changed the title Make cert usage generic [Kubernetes/Helm] Make cert usage generic Aug 18, 2019
@rajinator
Copy link
Contributor Author

Here are example changes for making cert usage generic. will open a PR after #156 is merged, since this contains those changes opensourcebapu@765bd87

This was referenced Aug 22, 2019
Closed
Merged
@sanketsudake sanketsudake added this to the v0.9.0 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
2 participants
@sanketsudake @rajinator