Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging package #262

Closed
PrasadG193 opened this issue Apr 21, 2020 · 1 comment
Closed

Refactor logging package #262

PrasadG193 opened this issue Apr 21, 2020 · 1 comment
Labels
good first issue Good for newcomers refactor Code refactoring. No functional changes

Comments

@PrasadG193
Copy link
Collaborator

Refactor logging package to make log statement simpler. Current format logging.Logger.Info() doesn't look good. We can embed Logrus into pkg/log to import and use it as log.Info()
@PrasadG193 PrasadG193 added refactor Code refactoring. No functional changes good first issue Good for newcomers labels Apr 21, 2020
@hmharsh hmharsh mentioned this issue Jun 11, 2020
Merged
mergify bot pushed a commit that referenced this issue Jun 16, 2020
@hmharsh
Refactor logging package (#262) (#285)
fc0e324 

##### ISSUE TYPE

 - Refactor Pull Request  (#262)


##### SUMMARY
Refactor logging package to make log statements simpler. Current format logging.Logger.Info() doesn't look good. We can embed Logrus into pkg/log to import and use it as log.Info()


Fixes #
- Embed Logrus into pkg/log 
- Update the reference to new log package
- Change the reference everywhere form 
    `logging.Logger.Function() --> log.Function()`
@PrasadG193
Copy link
Collaborator Author

Fixed with #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Code refactoring. No functional changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PrasadG193