Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Helm - indentation in clusterrole.yaml #267

Closed
OKyHb opened this issue Apr 29, 2020 · 1 comment · Fixed by #279
Closed

[BUG] Helm - indentation in clusterrole.yaml #267

OKyHb opened this issue Apr 29, 2020 · 1 comment · Fixed by #279
Labels
bug Something isn't working

Comments

@OKyHb
Copy link
Contributor

OKyHb commented Apr 29, 2020

When "podSecurityPolicy.enabled= true" I get this error with helm chart v0.10.0:

Error: YAML parse error on botkube/templates/clusterrole.yaml: error converting YAML to JSON: yaml: line 18: did not find expected key

To Reproduce
Steps to reproduce the behavior:

  1. Set "podSecurityPolicy.enabled= true" in values.yaml
  2. helm template -f values.yaml botkube infracloudio/botkube
  3. Get error

Additional context
Could you please fix the indentation in clusterrole.yaml? Use "nindent 2" on the line 13th or move "podSecurityPolicy" block two spaces to the right.
@OKyHb OKyHb added the bug Something isn't working label Apr 29, 2020
@PrasadG193
Copy link
Collaborator

PrasadG193 commented May 5, 2020 •
edited
Loading

Hey @OKyHb,
Thanks for reporting this. Would it be possible for you to raise the PR to fix this? Since you already know the resolution :)

@OKyHb OKyHb mentioned this issue May 7, 2020
Merged
@mergify mergify bot closed this as completed in #279 Jun 16, 2020
mergify bot pushed a commit that referenced this issue Jun 16, 2020
@OKyHb
Fix indentation for clusterrole in helm chart (#279)
dac4f71 
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
 - Bug fix Pull Request

##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->

<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
Fixes #267

With "nindent 2" helm doesn't throw an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix indentation for clusterrole in helm chart
2 participants
@OKyHb @PrasadG193