Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor fails to run when cluster-name is ignored [BUG] #300

Closed
gmkumar2005 opened this issue Jun 30, 2020 · 0 comments · Fixed by #301
Closed

Executor fails to run when cluster-name is ignored [BUG] #300

gmkumar2005 opened this issue Jun 30, 2020 · 0 comments · Fixed by #301
Labels
bug Something isn't working

Comments

@gmkumar2005
Copy link
Contributor

Describe the bug
Executor fails to run when namespace is ignored. For eg : get pods . While get pods -n micro works.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any channel (slack or telegram)
  2. Issue a kubectl command with single param eg " get pods
  3. Bot does not respond or returns empty results

Expected behavior
Bot should respond with a list of pods.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@gmkumar2005 gmkumar2005 added the bug Something isn't working label Jun 30, 2020
gmkumar2005 added a commit to gmkumar2005/botkube that referenced this issue Jun 30, 2020
@gmkumar2005
Allow kubectl commands wihtout namespace and without cluster-name
ba4ff0a 
    ##### ISSUE TYPE
    BUG

    ##### SUMMARY
    Default executor is expecting more than 2 arguments.
Fixed number of arguments needed to 1.

Fixes kubeshop#300
@gmkumar2005 gmkumar2005 mentioned this issue Jun 30, 2020
Merged
@mergify mergify bot closed this as completed in #301 Jun 30, 2020
mergify bot pushed a commit that referenced this issue Jun 30, 2020
@gmkumar2005
Allow kubectl commands wihtout namespace and without cluster-name (#301)
cc3fc6d 
    ##### ISSUE TYPE
     - Bug fix Pull Request

    ##### SUMMARY
    Default executor is expecting more than 2 arguments.
    Fixed number of arguments needed to 1.

Fixes #300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow kubectl commands without namespace and without cluster-name gmkumar2005/botkube
1 participant
@gmkumar2005