Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Error events are getting ignored after dynamic client change #339

Closed
PrasadG193 opened this issue Sep 19, 2020 · 0 comments · Fixed by #343
Closed

[BUG] Error events are getting ignored after dynamic client change #339

PrasadG193 opened this issue Sep 19, 2020 · 0 comments · Fixed by #343
Labels
bug Something isn't working release-blocker Upcoming release is blocked by this issue

Comments

@PrasadG193
Copy link
Collaborator

Describe the bug
BotKube skips error events event is the error events are configured in resource config

To Reproduce

  • Deploy BotKube with pod error events
  • Create a Pod with invalid image

Expected behavior
BotKube should report error event

Screenshots
If applicable, add screenshots to help explain your problem.
@PrasadG193 PrasadG193 added the bug Something isn't working label Sep 19, 2020
@PrasadG193 PrasadG193 added the release-blocker Upcoming release is blocked by this issue label Sep 19, 2020
This was referenced Sep 19, 2020
Closed
Merged
@mergify mergify bot closed this as completed in #343 Sep 21, 2020
mergify bot pushed a commit that referenced this issue Sep 21, 2020
@PrasadG193
Fix update and error event skip issue (#343)
f4994f1 
##### ISSUE TYPE
 - Feature Pull Request

##### SUMMARY

- Fix Allowed maps checks
- Update diff calculation logic

Fixes #339 #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release-blocker Upcoming release is blocked by this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix update and error event skip issue PrasadG193/botkube
1 participant
@PrasadG193