Develop #1
Merged
Develop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketsudake
commented
Dec 28, 2018
sanketsudake
commented
Dec 31, 2018
| _, controller := cache.NewInformer( | ||
| watchlist, | ||
| &apiV1.Event{}, | ||
| 30*time.Minute, |
There was a problem hiding this comment.
Make this configurable.
sanketsudake
commented
Dec 31, 2018
| return printDefaultMsg() | ||
| } | ||
| if args[1] == "start" { | ||
| config.Notify = true |
There was a problem hiding this comment.
add log messages here both in notify start/stop
sanketsudake
commented
Dec 31, 2018
| } | ||
| _, err := ValidServicePort(serviceName, ns, int32(servicePort)) | ||
| if err != nil { | ||
| event.Messages = append(event.Messages, "Warning: Service "+serviceName+" used in ingress config does not exist or port not exposed\n") |
There was a problem hiding this comment.
Remove Warning:
Message level already indicates it
sanketsudake
commented
Dec 31, 2018
| attachment.Color = attachmentColor[event.Level] | ||
| params.Attachments = []slack.Attachment{attachment} | ||
|
|
||
| log.Logger.Infof("Sending message on %v with token %s", s.Channel, s.Token) |
There was a problem hiding this comment.
avoid logging unwanted info . Credentials etc.
Sending message on channel %s
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.