Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md to add missing build step #117

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Update CONTRIBUTING.md to add missing build step #117

merged 2 commits into from
Jul 9, 2019

Conversation

kingdevnl
Copy link
Contributor

Update CONTRIBUTING.md to add missing build step

@kingdevnl
Copy link
Contributor Author

Iv'e added the make container-image
step to the list

@PrasadG193
Copy link
Collaborator

Hey @kingdevnl, thanks for the PR. Could you please rebase with develop?

@PrasadG193 PrasadG193 merged commit 2b75f90 into kubeshop:develop Jul 9, 2019
@kingdevnl
Copy link
Contributor Author

Sorry was away last week, for an vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingdevnl @PrasadG193 @sanketsudake