[feature] Add support for ignoring namespaces #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenio
force-pushed
the
feature/ignore-namespaces
branch
from
e09d097 to
907e427
Compare
|
rebased to develop |
sanketsudake
reviewed
Aug 2, 2019
codenio
force-pushed
the
feature/ignore-namespaces
branch
from
907e427 to
2e14225
Compare
|
resolved requested changes. |
|
Changes looks good to me. Please wait for review from @PrasadG193 |
PrasadG193
reviewed
Aug 5, 2019
codenio
force-pushed
the
feature/ignore-namespaces
branch
from
2e14225 to
9c40e62
Compare
|
Rebased to develop |
codenio
force-pushed
the
feature/ignore-namespaces
branch
from
9c40e62 to
2f9ba7d
Compare
|
rebased onto develop |
codenio
force-pushed
the
feature/ignore-namespaces
branch
from
2f9ba7d to
affb649
Compare
|
rebased onto |
codenio
force-pushed
the
feature/ignore-namespaces
branch
2 times, most recently
from
dc69973 to
baf1fa9
Compare
PrasadG193
reviewed
Aug 18, 2019
pkg/filterengine/filters/ignore-namespace-filter/ignore_namespace_checker.go
Outdated
Show resolved
Hide resolved
codenio
force-pushed
the
feature/ignore-namespaces
branch
from
baf1fa9 to
6874ae2
Compare
|
rebased onto develop |
This Commit, - adds support for ignoring certain namespaces while watching all namespaces using `IgnoreNamespaceChecker` - replaces `Namespaces []string` with `Namespaces.Include []string` - adds `Namespaces.Ignore []string` ( optional / omitempty ) filed to ignore namespaces when Namespaces.Inculde contains "all" - adds unit test cases for isNamespaceIgnored()
codenio
force-pushed
the
feature/ignore-namespaces
branch
from
6874ae2 to
fc69907
Compare
|
rebased onto develop. |
PrasadG193
approved these changes
Aug 20, 2019
|
Merged. Thanks @aananthraj |
|
@PrasadG193 thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
This PR, (updated)
Namespaces []stringwithNamespaces.Include []stringNamespaces.Ignore []string( optional / omitempty ) filed to ignore namespaces when Namespaces.Inculde contains "all"Fixes #128
This could allow as to watch all namespaces except a list of namespaces to ignore.
Example:
This config watches services of all namespaces except namespaces
developmentandstaging