Add E2E Integration tests #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
force-pushed
the
integration-tests
branch
2 times, most recently
from
e22d9de to
36ecb9e
Compare
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
integration-tests
branch
2 times, most recently
from
c834d0b to
35a3988
Compare
Add CommandRunner interface and fake_executor to mock kubectl command execution Add warnings field to the Event struct Update filter recommendation message format Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
integration-tests
branch
from
35a3988 to
b1d71a6
Compare
|
Negative tests are yet to be added, will raise separate PR for that |
Rename hack/unit-test.sh to hack/runtests.sh Modify make target unit-test to test Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
integration-tests
branch
from
b1d71a6 to
5f0f456
Compare
sanketsudake
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
This PR:
To Run:
go test -tags=test ./test/e2e/ -v OR ./hack/runtests.sh OR make test
Fixes #136