Checked cluster name before executing kubectl command #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketsudake
reviewed
Feb 5, 2020
pkg/utils/utils_test.go
Outdated
| result := GetClusterNameFromKubectlCmd(str) | ||
|
|
||
| if result != "minikube" { | ||
| t.Errorf("Expecte minikube but got %v ", result) |
There was a problem hiding this comment.
expected instead of Expecte
pkg/utils/utils.go
Outdated
|
|
||
| //GetClusterNameFromKubectlCmd this will return cluster name from kubectl command | ||
| func GetClusterNameFromKubectlCmd(cmd string) string { | ||
| i := strings.Index(cmd, "--cluster-name") + 15 //15 indicates 15 letters in --cluster-name string with space or equal |
There was a problem hiding this comment.
Please see if we could use valid regex instead.
There was a problem hiding this comment.
Not as a part of this PR but we should use cli parser (like github.com/urfave/cli) to parse BotKube commands.
sanketsudake
reviewed
Feb 6, 2020
girishg4t
force-pushed
the
bugfix/multicluster
branch
from
5121cea to
0fc5eba
Compare
PrasadG193
reviewed
Feb 6, 2020
pkg/utils/utils.go
Outdated
| r, _ := regexp.Compile(`--cluster-name[=|' ']([^\s]*)`) | ||
| //this gives 2 match with cluster name and without | ||
| matchedArray := r.FindStringSubmatch(cmd) | ||
| var s string = "" |
There was a problem hiding this comment.
Minor:
Suggested change
| var s string = "" | |
| var s string |
sanketsudake
approved these changes
Feb 6, 2020
PrasadG193
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the bug 230 which shows redundant error message
when deployed in miticluster, added check for cluster name and
created new function to get cluster name from kubectl command