Fixes #179: Migration of current travis ci to github-actions ci. #244
Conversation
Needed to update the golint path to $GOPATH/bin/golint to fix github-actions build failure. Added docker push action step in current CI steps. Added helm release step along with missing "helm init".
Replaced helm repo, git branch
| env: | ||
| GO111MODULE: on | ||
| GOPATH: /home/runner/work/botkube | ||
| GOBIN: /home/runner/work/botkube/bin |
There was a problem hiding this comment.
What is $HOME value? Can we use $HOME to set the path?
There was a problem hiding this comment.
the value for $HOME is /home/runner but it gives error if we try to assign value of GOPATH to a relative path.
Check error.
so I think we need to give absolute path which would be /home/runner or can keep the same value.
.github/workflows/ci.yml
Outdated
| git branch | ||
| git pull origin gh-pages | ||
| helm init --client-only | ||
| helm package --app-version v9.99.9-ci-test --version v9.99.9-dev ${{ github.workspace }}/helm/botkube/ |
There was a problem hiding this comment.
Please keep --app-version same as --version i.e v9.99.9-dev
There was a problem hiding this comment.
yes sure, will update the change. I missed that
|
Thanks for the PR @ameydev. LGTM |
Your welcome! just a reminder GH_TOKEN(github access token of charts repo) |
|
@ameydev We should get this merged early in this release cycle. Could you please remove |
|
@PrasadG193 I think we can keep travis and gh-actions both active for a while and once we make sure everything is working fine, can remove .travis.yaml. |
ISSUE TYPE
Fix for issue githib-actions
SUMMARY
Checklist for Enabling github actions:
make sure to add below secrets in repo/settings/secrets
For reference the tested CI workflows on my repos: