helm fixes

[eddycharly]

ISSUE TYPE

• Bug fix Pull Request

SUMMARY

Fixing #257 and #258.

[PrasadG193]

Looks good. @eddycharly Could you please also update release script to overwrite the default image tag in values.yaml?
https://github.com/infracloudio/botkube/blob/develop/hack/release.sh#L27

[eddycharly]

How do you want to get this done ?

Here the chart version should be bumped but there’s no need to change the image version.

I mean the chart can evolve without changing the image (nodeSelector for exemple is only a chart concern).

[PrasadG193]

We have address the release script change in separate PR. We just need to add one more sed statement (like https://github.com/infracloudio/botkube/blob/develop/hack/release.sh#L31) to update the tag: in value.yaml

[eddycharly]

Let's say we create a v0.9.2 release, the version is extracted form the version tag.

How can we set the chart version to v0.9.2 and image tag to v0.9.1 ?
I don't see a way to decouple chart version and image tag.

[PrasadG193]

@eddycharly We do application and chart release at the same time with the same tag.

[eddycharly]

@PrasadG193 i made the requested changes in release.sh

[eddycharly]

@PrasadG193 any chance to get a release soon ?

[PrasadG193]

@eddycharly We are working on adding/updating documentation. We should be able to release by this weekend

[eddycharly]

Thanks 👍

[eddycharly]

@PrasadG193 If it helps, you can use helm-docs to generate helm chart doc automatically.

I can open a PR for that if you're interested.

[PrasadG193]

@eddycharly That looks great. Let me see if I can automate the doc generation. BTW, we maintain documentation in a separate repo here: https://github.com/infracloudio/botkube-docs