adding feature to support AWS Signing and creating new index per day #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 30, 2020 18:50
…using DD-MM-YYYY suffix
…using DD-MM-YYYY suffix
…om/infracloudio/botkube into feature/support-aws-signing-for-es
PrasadG193
requested changes
Jun 30, 2020
comm_config.yaml
Outdated
| awsRegion: "us-east-1" # AWS region where Elasticsearch is deployed | ||
| awsAccessKey: "" | ||
| awsSecretKey: "" | ||
| server: "" # e.g https://example.com:9243 |
There was a problem hiding this comment.
Suggested change
| server: "" # e.g https://example.com:9243 | |
| server: 'ELASTICSEARCH_ADDRESS' # e.g https://example.com:9243 |
pkg/config/config.go
Outdated
| Name string | ||
| Type string | ||
| Shards int | ||
| Replicas int |
There was a problem hiding this comment.
Please run go fmt. I don't think this change is required
pkg/notify/elasticsearch.go
Outdated
| awsClient, err := aws_signing_client.New( | ||
| signer, | ||
| nil, | ||
| "es", |
There was a problem hiding this comment.
What is "es"? Please declare it as a const.
pkg/notify/elasticsearch.go
Outdated
| // Get credentials from environment variables and create the AWS Signature Version 4 signer | ||
| creds := credentials.NewEnvCredentials() | ||
| signer := v4.NewSigner(creds) | ||
| awsClient, err := aws_signing_client.New( |
There was a problem hiding this comment.
Please keep the function params in single line. It easier to read that way
pkg/notify/elasticsearch.go
Outdated
| @@ -78,7 +121,7 @@ func (e *ElasticSearch) SendEvent(event events.Event) (err error) { | |||
| event.Cluster = e.ClusterName | |||
|
|
|||
| // Create index if not exists | |||
| exists, err := e.ELSClient.IndexExists(e.Index).Do(ctx) | |||
| exists, err := e.ELSClient.IndexExists(e.Index + "-" + time.Now().Format("02-01-2006")).Do(ctx) | |||
There was a problem hiding this comment.
Please declare format string as a const and use that
|
@kartik-moolya Please run |
ghost
force-pushed
the
feature/support-aws-signing-for-es
branch
from
5f5073b to
65af86f
Compare
PrasadG193
requested changes
Jul 1, 2020
PrasadG193
requested changes
Jul 1, 2020
|
Please fix the gofmt issues. |
ghost
force-pushed
the
feature/support-aws-signing-for-es
branch
from
e63e711 to
cf3beff
Compare
PrasadG193
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Allows user to specify if Elasticsearch is hosted on AWS
Includes feature which would allow botkube to send Kubernetes events to Elasticsearch hosted on AWS
Secondly creates new index per day with index name suffixed as -DD-MM-YYYY
Fixes #299
Fixes #283