Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): correct indentation for rbac rules #356

Merged
merged 2 commits into from
Nov 2, 2020
Merged

fix(charts): correct indentation for rbac rules #356

merged 2 commits into from
Nov 2, 2020

Conversation

aslafy-z
Copy link
Contributor

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

Correctly indent RBAC rules. It was previously throwing an error when enabling both psp and rbac at the value level.

Fixes #325

@aslafy-z aslafy-z marked this pull request as draft September 30, 2020 10:11
@PrasadG193
Copy link
Collaborator

Hey @aslafy-z,
Thanks for the PR. Please let us know when the PR is ready for review

@gauravgahlot
Copy link

@aslafy-z Please rebase your branch once ready.

@aslafy-z aslafy-z marked this pull request as ready for review October 24, 2020 10:20
@PrasadG193
Copy link
Collaborator

@aslafy-z can you please provide an output of
helm install --name botkube --namespace botkube --set rbac.create=true,podSecurityPolicy.enabled=true ./helm/botkube --dry-run --debug?

@aslafy-z
Copy link
Contributor Author

out.log
Here's the output.

@mergify mergify bot merged commit f5dce1f into kubeshop:develop Nov 2, 2020
@aslafy-z aslafy-z deleted the patch-1 branch November 2, 2020 06:23
@chetanpdeshmukh
Copy link

Hello @aslafy-z
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@asoni90 asoni90 Awaiting requested review from asoni90

@bhavin192 bhavin192 Awaiting requested review from bhavin192

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Helm Chart clusterrole invalid if PSP and rbac are both enabled
4 participants
@aslafy-z @PrasadG193 @gauravgahlot @chetanpdeshmukh