Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for kubectl command on forbidden verbs and resources #374

Merged
merged 5 commits into from
Oct 1, 2020

Conversation

anoopmsivadas
Copy link
Contributor

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

Added a e2e test kubectl command with forbidden verb and forbidden resource. Another one for kubctl command with allowed verb and forbidden resource

Fixes #350

@PrasadG193
Copy link
Collaborator

Thanks for the PR @anoopmsivadas 🙏

@PrasadG193
Copy link
Collaborator

@anoopmsivadas Could you please rebase with develop and push again?

@mergify mergify bot merged commit d92ca25 into kubeshop:develop Oct 1, 2020
@chetanpdeshmukh
Copy link

Hello @anoopmsivadas ,
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for executing kubectl command on forbidden verbs and resources
3 participants