Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added testcases for skip delete event for resources not configured #377

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

akankshakumari393
Copy link
Contributor

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

Added skip delete event test case that should be skipped for resources which are not configured for delete event in test config.
Modified the resource configuration map AllowedEventKindsMap and removed delete event for pod.

Fixes test case - Validate delete events are skipped when delete event is not configured for a resources in test config. e.g events: [create, update, error] of issue #354

@mergify mergify bot merged commit 9a6bc57 into develop Oct 1, 2020
@mergify mergify bot deleted the issue_354 branch October 1, 2020 13:16
@chetanpdeshmukh
Copy link

Hello @A-kanksh-a ,
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants