Issues #37 and #16: Added multi-cluster support and added cluster-name in botkube commands #38
+249
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Feb 19, 2019
mugdha-adhav
force-pushed
the
infracloudio/add-cluster-name
branch
3 times, most recently
from
266088e to
4b3696a
Compare
mugdha-adhav
changed the title
mugdha-adhav
force-pushed
the
infracloudio/add-cluster-name
branch
2 times, most recently
from
e521932 to
f236a17
Compare
mugdha-adhav
changed the title
mugdha-adhav
force-pushed
the
infracloudio/add-cluster-name
branch
2 times, most recently
from
6b57edb to
91796a6
Compare
mugdha-adhav
force-pushed
the
infracloudio/add-cluster-name
branch
from
91796a6 to
f357fa6
Compare
sanketsudake
approved these changes
Feb 26, 2019
mugdha-adhav
force-pushed
the
infracloudio/add-cluster-name
branch
from
f357fa6 to
53cd88b
Compare
…c information. Issue #16: Added cluster-name in kubectl, notifier and ping messages from botkube.
mugdha-adhav
force-pushed
the
infracloudio/add-cluster-name
branch
from
53cd88b to
e82a1d7
Compare
PrasadG193
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cluster name in the notifier, start, stop and botkube commands.