Codespell action for BotKube #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Oct 2, 2020
| - Setting default namespace while executing kubectl commands [\#176](https://github.com/infracloudio/botkube/issues/176) | ||
| - Add Microsoft Teams suppport [\#60](https://github.com/infracloudio/botkube/issues/60) | ||
| - Add Microsoft Teams support [\#60](https://github.com/infracloudio/botkube/issues/60) |
There was a problem hiding this comment.
@sanketsudake this will be altered next time we run changelog_generator, the correct fix would be to fix the issues/PRs names so that next time when it tried to generate changelog, it will get correct names
There was a problem hiding this comment.
I have corrected typos in respective issues and PRs referred from changelog. Also, keeping this change so that Github action passes.
@PrasadG193 Please let me know if this helps.
There was a problem hiding this comment.
Sounds good. Thanks @sanketsudake
PrasadG193
approved these changes
Oct 5, 2020
sanketsudake
force-pushed
the
ci_additional_checks
branch
from
3b2f80e to
d802d70
Compare
This commit adds GitHub action which checks for common misspellings across repository.
sanketsudake
force-pushed
the
ci_additional_checks
branch
from
d802d70 to
a20d6fe
Compare
PrasadG193
approved these changes
Oct 5, 2020
|
Hello @sanketsudake , Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂 Team BotKube |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds GitHub action which checks for common misspellings across the repository.
ISSUE TYPE
SUMMARY
This commit adds codespell action in CI workflow which enables verification of common misspellings across the repository.
Also fixed existing codespell issues.