Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test case to validate error event #410

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Added test case to validate error event #410

merged 1 commit into from
Oct 26, 2020

Conversation

Divya063
Copy link
Contributor

@Divya063 Divya063 commented Oct 11, 2020 •
edited
Loading

  • Validates error events are skipped when the error event is not configured for a resource in test config.
  • Validate that error events are skipped when an event occurs for a namespace which is not added in resource_config
    Fixes part of Add test coverage for error events #340

@Divya063 Divya063 force-pushed the error-test branch 3 times, most recently from 1aeb6ef to 0266e04 Compare October 11, 2020 13:08
@PrasadG193 PrasadG193 self-requested a review October 14, 2020 12:17
PrasadG193
PrasadG193 reviewed Oct 15, 2020
View reviewed changes
test/e2e/notifier/error/error.go Outdated
Comment on lines 49 to 56
isAllowed := utils.AllowedEventKindsMap[utils.EventKind{
Resource: resource,
Namespace: "all",
EventType: config.ErrorEvent}] ||
utils.AllowedEventKindsMap[utils.EventKind{
Resource: resource,
Namespace: test.Namespace,
EventType: config.ErrorEvent}]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Divya063 Let's use utils.CheckOperationAllowed() method we recently added to check if event allowed. Please rebase with the latest develop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrasadG193 Sure!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrasadG193 Done!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Divya063 did you miss committing the changes? I don't see this resolved

@mergify mergify bot merged commit d5b3d6c into kubeshop:develop Oct 26, 2020
@chetanpdeshmukh
Copy link

Hello @Divya063 ,
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Divya063 @chetanpdeshmukh @PrasadG193