feat(slack): clean up empty cmd handling #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Nov 2, 2020
| if len(sm.Request) == 0 { | ||
| return | ||
| } | ||
| sm.Request = strings.TrimPrefix(sm.Event.Text, "<@"+sm.BotID+">") |
There was a problem hiding this comment.
Does empty command e.g @BotKube return an error message now?
There was a problem hiding this comment.
Yes it does.
this is managed by the executor : https://github.com/infracloudio/botkube/pull/424/files#diff-fccd3962f0d0da63e38e16963f1ac9ecdc37cbbe33beed7e6aee1d0de163f4e1R183
This way there is a common behaviour between all integrations
There was a problem hiding this comment.
@sgandon could you confirm this? Rest looks good
|
Sorry about that my response was in pending state, I forgot to submit it. |
|
Cool! Thanks @sgandon |
PrasadG193
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
The empty command
@BotKubeis managed in the executor.go file for having a identic behaviour on all intergrations but the Slack bot is handling it differently.So I proposed a cleanup in this PR.