SSL support for Mattermost in Botkube #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mugdha-adhav Do we need to add CA certificate while deploying BotKube backend? |
sanketsudake
approved these changes
Apr 26, 2019
mugdha-adhav
force-pushed
the
mattermost-ssl-support
branch
from
a3de158 to
f2048fb
Compare
PrasadG193
reviewed
May 6, 2019
|
Fixes: #81 |
PrasadG193
approved these changes
May 6, 2019
sanketsudake
approved these changes
May 7, 2019
|
@mugdha-adhav Could you also update related docs and raise PR against botkube-docs develop branch? |
mugdha-adhav
force-pushed
the
mattermost-ssl-support
branch
from
f2048fb to
7640a42
Compare
|
@mugdha-adhav can you please rebase with develop? |
mugdha-adhav
force-pushed
the
mattermost-ssl-support
branch
from
7640a42 to
24eb71e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested for self signed certificates in Mattermost
Closes #81